Skip to content

Use rabbitmq length for RabbitMQNodeNotDistributed #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Use rabbitmq length for RabbitMQNodeNotDistributed #1702

merged 1 commit into from
Jun 12, 2025

Conversation

seunghun1ee
Copy link
Member

This complements #1579
Would be good to be backported to stackhpc/2024.1

@seunghun1ee seunghun1ee self-assigned this Jun 11, 2025
@seunghun1ee seunghun1ee requested a review from a team as a code owner June 11, 2025 14:07
@product-auto-label product-auto-label bot added size: xs monitoring All things related to observability & telemetry labels Jun 11, 2025
@Alex-Welsh
Copy link
Member

/cherry-pick stackhpc/2024.1

@Alex-Welsh
Copy link
Member

/cherry-pick stackhpc/2024.1

Apparently it's possible to do this while a PR is open and it'll automatically do the cherry-pick after it merges

@seunghun1ee seunghun1ee merged commit c9c3eba into stackhpc/2025.1 Jun 12, 2025
17 of 18 checks passed
@seunghun1ee seunghun1ee deleted the update-rabbitmq-rule branch June 12, 2025 09:12
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 12, 2025
@seunghun1ee
Merge pull request #1702 from stackhpc/update-rabbitmq-rule
23ef04a 
Use rabbitmq length for ``RabbitMQNodeNotDistributed``
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 12, 2025
Merged
Alex-Welsh added a commit that referenced this pull request Jun 12, 2025
@Alex-Welsh
Merge pull request #1703 from stackhpc/cherry-pick-0bd6d0-stackhpc/20…
3d8c704 
…24.1

Use rabbitmq length for ``RabbitMQNodeNotDistributed`` (cherry-pick #1702)
jackhodgkiss added a commit that referenced this pull request Aug 2, 2025
@jackhodgkiss
Revert "Merge pull request #1702 from stackhpc/update-rabbitmq-rule"
2c7a602 
This reverts commit c9c3eba, reversing
changes made to ddd4daa.

The metric `erlang_vm_dist_node_state` should not be compared against
the size of the `RabbitMQ` cluster as the values indicate the current
state of the link with `3` implying the connection is `up`.
Alex-Welsh pushed a commit that referenced this pull request Aug 4, 2025
@jackhodgkiss @Alex-Welsh
Revert "Merge pull request #1702 from stackhpc/update-rabbitmq-rule"
015ffb7 
This reverts commit c9c3eba, reversing
changes made to ddd4daa.

The metric `erlang_vm_dist_node_state` should not be compared against
the size of the `RabbitMQ` cluster as the values indicate the current
state of the link with `3` implying the connection is `up`.
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 5, 2025
@jackhodgkiss @Alex-Welsh
Revert "Merge pull request #1702 from stackhpc/update-rabbitmq-rule"
b2b8226 
This reverts commit c9c3eba, reversing
changes made to ddd4daa.

The metric `erlang_vm_dist_node_state` should not be compared against
the size of the `RabbitMQ` cluster as the values indicate the current
state of the link with `3` implying the connection is `up`.
jackhodgkiss added a commit that referenced this pull request Aug 19, 2025
@jackhodgkiss
Revert "Use rabbitmq length for RabbitMQNodeNotDistributed (cherr…
4a3a494 
…y-pick #1702)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoteHue MoteHue MoteHue approved these changes

@Alex-Welsh Alex-Welsh Alex-Welsh approved these changes

@jackhodgkiss jackhodgkiss Awaiting requested review from jackhodgkiss

Assignees

@seunghun1ee seunghun1ee

Labels
monitoring All things related to observability & telemetry size: xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seunghun1ee @Alex-Welsh @MoteHue