Upstream magnum

[seunghun1ee]

Our downstream Magnum [1] was for keeping Heat driver support.
But we dropped them, so there's no need to build magnum from downstream.

[1] stackhpc/magnum#202

[gemini-code-assist]

Summary of Changes

Hello @seunghun1ee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've made changes to align our Magnum build process with upstream sources. This is a direct result of dropping Heat driver support, which was the original reason for maintaining a downstream Magnum build. The updates involve adjusting Kolla configuration files to reflect this shift, ensuring we now pull Magnum images from their official upstream locations and no longer reference our custom downstream repository.

Highlights

• Magnum Image Tagging: I've added new magnum image tags for both rocky-9 and ubuntu-noble distributions in etc/kayobe/kolla-image-tags.yml. This ensures that the correct upstream Magnum images are referenced for these environments.
• Magnum Source Removal: I've removed the magnum-base git source definition from etc/kayobe/kolla.yml. This change reflects the decision to no longer build Magnum from a custom downstream repository, aligning with the move to upstream.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the configuration to use upstream Magnum by removing the custom source from kolla_sources and adding the necessary image tags. This aligns with the stated goal of moving away from the downstream fork. I have one concern about a potential regression, which I've detailed in a comment on etc/kayobe/kolla.yml.

[Alex-Welsh]

Need to be careful this doesn't conflict with #1819

[seunghun1ee]

I'll rebuild again to include that change

[Alex-Welsh]

Now that Epoxy is stable, we should also include release notes for container image rebuilds

[Alex-Welsh]

If only we could test Magnum in CI 😢