-
Notifications
You must be signed in to change notification settings - Fork 23
Bring fix for py3.12 pyyaml missing on kayobe build #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @seunghun1ee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a known bug in kayobe-automation
where the pyyaml
package was not installing correctly when Python 3.12 was used with the USE_PYTHON_312
flag. The fix is implemented by updating the kayobe-automation
git submodule to a version that contains the necessary patch, ensuring proper dependency resolution for Python 3.12 environments.
Highlights
- Submodule Update: Updates the
.automation
submodule to a newer commit (68a34ce...) which incorporates a fix for apyyaml
installation issue withinkayobe-automation
when Python 3.12 is enabled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the kayobe-automation
submodule to a new commit, addressing a pyyaml
installation issue when using Python 3.12. While the submodule update is correct, the change is missing an accompanying release note, which is important for project maintainability and tracking. I have added a comment to highlight the need for a release note.
There was a bug in kayobe-automation that pyyaml is not installed properly when using python 3.12 with ``USE_PYTHON_312``. This commit brings kayobe-automation change [1]. [1] stackhpc/kayobe-automation#77
2efeeab
to
4aa0f20
Compare
There was a bug in kayobe-automation that pyyaml is not installed properly when using python 3.12 with
USE_PYTHON_312
. This commit brings kayobe-automation change [1].[1] stackhpc/kayobe-automation#77