-
Notifications
You must be signed in to change notification settings - Fork 23
Fix Grafana project metrics dashboard #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Grafana project metrics dashboard #1843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Alex-Welsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves issues with the Grafana project metrics dashboard by integrating a newer version of the Prometheus Libvirt exporter. It updates the dashboard's PromQL queries to align with the new metric names and structure provided by the updated exporter, ensuring accurate display of project-level resource utilization. Additionally, it includes various dashboard panel enhancements for improved visualization.
Highlights
- Prometheus Libvirt Exporter Update: The
prometheus_libvirt_exporter
image tags have been updated inetc/kayobe/kolla-image-tags.yml
for Rocky 9, Ubuntu Jammy, and Ubuntu Noble, reflecting an upgrade of the exporter fromv1.6.0
tov2.2.0
. - Grafana Dashboard Query Adjustments: The
grafana_project_dashboard.json
file has been extensively modified to update PromQL queries. Metric names such aslibvirt_domain_info_meta
andproject_uuid
have been replaced withlibvirt_domain_openstack_info
andproject_id
respectively, andflavor
withflavor_name
, to correctly fetch data from the new exporter. - Dashboard Panel Enhancements: Various visual and functional enhancements have been applied to the Grafana dashboard panels, including updating the Grafana plugin version to
12.0.1+security-01
, adjusting color step values, adding new display options for legends, axis borders, and bar widths, and changing panel titles from 'per instance' to 'per project' for CPU, Memory, and Disk utilization. - Release Note Added: A new release note (
releasenotes/notes/fix-libvirt-dashboard-b33327f804bea5f9.yaml
) has been added to document the fix and the specific version upgrade of the Prometheus Libvirt exporter.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully fixes the Grafana project metrics dashboard by updating it for a new version of the Prometheus Libvirt exporter. The changes involve updating image tags, modifying dashboard settings to align with a newer Grafana version, and updating PromQL queries to use new metric names and labels. A release note is also included. The changes are well-executed, but I've identified one minor inconsistency in a PromQL query that should be addressed for correctness.
etc/kayobe/kolla/config/grafana/dashboards/openstack/grafana_project_dashboard.json
Outdated
Show resolved
Hide resolved
1b51f11
to
5eed6fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds new prometheus libvirt exporter container with correct metrics and edits to the PromQL queries to use the new metrics (some of them use different names to the first exporter we used)
Fixed dashboard example:

I'm submitting this for Caracal first because the kolla pins haven't been bumped yet in Epoxy, see #1836