-
Notifications
You must be signed in to change notification settings - Fork 23
rocky/aarch64: switch to versioned Erlang 26/27 repos #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bbezak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the repository configurations for Erlang on aarch64 systems within the Rocky Linux environment. The primary goal is to transition from a generic Erlang COPR to explicitly versioned Erlang 26 and 27 repositories. This change is essential for maintaining compatibility with the latest RabbitMQ versions and ensures alignment with upstream Kolla project updates, improving the stability and currency of the build and deployment processes for relevant components.
Highlights
- Erlang Repository Update: Switched aarch64 Erlang COPR repositories from unversioned to specific Erlang 26 and Erlang 27 versions. This change is crucial for supporting newer RabbitMQ versions (4.0/4.1) and aligns with recent updates in Kolla.
- Configuration Variable Additions: Introduced new configuration variables across various YAML files (e.g.,
ci-aio
,ci-builder
,ci-multinode
,pulp-repo-versions
,pulp
,stackhpc
) to manage the new versioned Erlang 26 and 27 repositories, specifically for aarch64 architectures. - Kolla Image Tag and Source Version Updates: Added new Kolla image tags for
kolla-toolbox
andrabbitmq
onrocky-9
and updated thestackhpc_kolla_source_version
tostackhpc/20.1.0.11
, ensuring consistency with the broader Kolla ecosystem. - Repository File Existence Check Improvement: Modified the
kolla.yml
to include a conditional check (if [ -f /etc/yum.repos.d/{{ repo.file }} ]; then
) before attempting to modify repository files, preventing errors if a specific repo file does not exist.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
86eac8d
to
fec66f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request switches to versioned Erlang 26/27 repositories for aarch64
on Rocky Linux, aligning with a corresponding change in Kolla. The changes are consistently applied across various configuration files, including environment definitions, Pulp settings, and Kolla build configurations. The logic for handling architecture-specific repository versions appears correct, and a release note has been added to document the upgrade. I have one suggestion to improve code readability in one of the YAML files.
fec66f8
to
e77b05f
Compare
e77b05f
to
e93c1c8
Compare
Replace unversioned aarch64 Erlang COPR with erlang-26 and erlang-27 Aligns with Kolla change [1]. [1] https://review.opendev.org/c/openstack/kolla/+/959323 Signed-off-by: Bartosz Bezak <[email protected]>
aa4f740
to
76f7e3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does the SBOM tell you the package sources by the way?
can't find anything which shows specific repo - for instance pulp in the sbom.json .
|
Replace unversioned aarch64 Erlang COPR with erlang-26 and erlang-27 Aligns with Kolla change [1]. [1] https://review.opendev.org/c/openstack/kolla/+/959323 Signed-off-by: Bartosz Bezak <[email protected]>
Replace unversioned aarch64 Erlang COPR with erlang-26 and erlang-27.
Aligns with Kolla change [1].
[1] https://review.opendev.org/c/openstack/kolla/+/959323