Ubuntu Noble rabbitmq image rebuild with correct Erlang #1868
Conversation
Followed upstream [1]. [1] https://review.opendev.org/c/openstack/kolla/+/959426
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bbezak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue with the Erlang PPA suite used for building RabbitMQ images on Ubuntu Noble. It ensures that the correct Erlang versions are utilized by updating the PPA source, which necessitated a rebuild of the affected images and subsequent updates to their respective image tags.
Highlights
- RabbitMQ Erlang PPA Fix: The RabbitMQ image for Ubuntu Noble has been rebuilt to use the correct Erlang PPA suite, specifically transitioning from "jammy" to "noble" for Erlang versions 26/27.
- Image Tag Updates: The kolla_toolbox and rabbitmq image tags for ubuntu-noble have been updated to reflect the recent rebuilds and ensure the use of the latest corrected images.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the image tags for rabbitmq and kolla_toolbox for Ubuntu Noble to use a new build that includes a fix for the Erlang PPA. A release note is also added. The changes look good, but I have a couple of suggestions to improve clarity and consistency. Firstly, the update to kolla_toolbox should be reflected in the PR title and release note. Secondly, the release note text could be rephrased for better readability. Please see my detailed comments.
Followed upstream [1].
[1] https://review.opendev.org/c/openstack/kolla/+/959426