-
Notifications
You must be signed in to change notification settings - Fork 23
rocky/aarch64: switch to versioned Erlang 26/27 repos #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bbezak, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the Erlang repository sources for aarch64 systems to use specific versioned repositories (Erlang 26 and 27). This change is crucial for maintaining compatibility with the latest RabbitMQ versions and aligning the system with recent Kolla project updates, ensuring a stable and up-to-date environment for dependent services.
Highlights
- Erlang Repository Update: Switched aarch64 Erlang RPMs from an unversioned COPR to versioned
erlang-26
anderlang-27
COPR repositories for Rocky 9. This change specifically targets aarch64 architectures, while x86_64 remains unaffected. - RabbitMQ Compatibility: The repository switch is implemented to support newer RabbitMQ versions (3.13/4.1) and ensure alignment with recent changes in Kolla, enhancing compatibility and future-proofing the setup.
- Configuration Updates: Introduced new variables and updated existing configurations across various YAML files to reflect the new versioned Erlang repositories and their corresponding URLs. This includes updates to CI environment definitions, image tags, and Pulp repository versions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request switches to versioned Erlang repositories for aarch64 to align with a Kolla change. The changes involve updating several YAML configuration files to introduce new repository definitions and image tags. While the intent is clear, I've identified a critical typo in an image tag and a logical flaw in how repository versions are determined, which could lead to incorrect URLs and build failures. Please see the detailed comments.
Replace unversioned aarch64 Erlang COPR with erlang-26 and erlang-27 Aligns with Kolla change [1]. [1] https://review.opendev.org/c/openstack/kolla/+/959692 (cherry picked from commit 52ad7b2) Signed-off-by: Bartosz Bezak <[email protected]>
15ce48e
to
5c26b58
Compare
Replace unversioned aarch64 Erlang COPR with erlang-26 and erlang-27 Aligns with Kolla change [1].
[1] https://review.opendev.org/c/openstack/kolla/+/959692
(cherry picked from commit 52ad7b2)