Fix RabbitMQ queue migration host command run

[Alex-Welsh]

Fixes CI failures caused when you don't have designate running so systemctl stop fails

[gemini-code-assist]

Summary of Changes

Hello @Alex-Welsh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the reliability of the RabbitMQ queue migration process by resolving a specific CI failure. The issue arose when the systemctl stop command for Designate services would fail if Designate was not deployed, causing the entire migration script to halt. The change ensures that this command gracefully handles the absence of Designate services, allowing the migration to proceed without interruption.

Highlights

• CI Stability: Addresses and resolves CI failures that occurred during RabbitMQ queue migration when the Designate service was not active.
• Robustness Improvement: Enhances the rabbitmq-queue-migration.sh script by making the systemctl stop command for Designate services fault-tolerant, preventing script termination if Designate is not running.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request fixes a CI failure where the script would fail if no Designate services were running. The proposed change of adding || true solves the immediate issue but is a bit of a blunt instrument, as it would suppress any and all errors from the command pipeline, including legitimate failures. I've suggested a more robust solution that also fixes an underlying bug in the command where it was not selecting the correct service name to stop.

[Alex-Welsh]

Tested here #1883

[Alex-Welsh]

Upgrade jobs worked, ready for review