Skip to content

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Sep 25, 2025

No description provided.

@MoteHue MoteHue requested a review from a team as a code owner September 25, 2025 12:05
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Prometheus alert, RadosGWUsageExporterNotServingMetrics, to monitor the RadosGW Usage Exporter, and includes a corresponding release note. My review identified a critical issue with the Prometheus rule definition that will result in an invalid file, preventing Prometheus from loading it. I have also noted a minor typo in the release note. Please see the detailed comments for suggestions on how to resolve these issues.

@MoteHue MoteHue force-pushed the alert-on-radosgw-usage-exporter branch from 7cffca7 to c14dfc2 Compare September 25, 2025 12:16
@MoteHue
Copy link
Contributor Author

MoteHue commented Sep 25, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Prometheus alert, RadosGWUsageExporterNotServingMetrics, to monitor the RadosGW Usage Exporter, along with a corresponding release note. The new alert is a valuable addition for ensuring the reliability of RGW usage metrics collection. However, I've identified a critical issue with how the new alert rule is added to the configuration file, which will result in an invalid YAML file and cause Prometheus rule loading to fail. My review includes a detailed explanation of the issue and guidance on how to resolve it.

priteau
priteau previously approved these changes Sep 30, 2025
Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extend this to all our critical metrics.

dougszumski
dougszumski previously approved these changes Oct 1, 2025
@MoteHue MoteHue enabled auto-merge October 1, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants