-
Notifications
You must be signed in to change notification settings - Fork 23
Add alerting for RadosGW Usage Exporter metrics #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Prometheus alert, RadosGWUsageExporterNotServingMetrics
, to monitor the RadosGW Usage Exporter, and includes a corresponding release note. My review identified a critical issue with the Prometheus rule definition that will result in an invalid file, preventing Prometheus from loading it. I have also noted a minor typo in the release note. Please see the detailed comments for suggestions on how to resolve these issues.
releasenotes/notes/alert-on-radosgw-usage-exporter-8f03f7013204ea22.yaml
Outdated
Show resolved
Hide resolved
6efbcc5
to
7cffca7
Compare
7cffca7
to
c14dfc2
Compare
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Prometheus alert, RadosGWUsageExporterNotServingMetrics
, to monitor the RadosGW Usage Exporter, along with a corresponding release note. The new alert is a valuable addition for ensuring the reliability of RGW usage metrics collection. However, I've identified a critical issue with how the new alert rule is added to the configuration file, which will result in an invalid YAML file and cause Prometheus rule loading to fail. My review includes a detailed explanation of the issue and guidance on how to resolve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should extend this to all our critical metrics.
a0ac188
to
e125e69
Compare
No description provided.