Fixes for bug 2119646 [Zed] #1967
Merged
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Keystone container image tag to address a security vulnerability (bug 2119646), which allows unauthenticated access to EC2/S3 token endpoints. A release note has been added to document this security fix. The changes are correct, but I have one minor suggestion regarding the ordering of services in the YAML configuration file for better maintainability.
Comment on lines
+24
to
+26
| keystone: | ||
| rocky-9: zed-rocky-9-20251031T100240 | ||
| ubuntu-jammy: zed-ubuntu-jammy-20251031T100240 |
There was a problem hiding this comment.
To maintain consistency and readability, the services in this list should be kept in alphabetical order. The keystone block should be placed after the horizon block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.