-
Notifications
You must be signed in to change notification settings - Fork 1
Add EL8/9 CernVM-FS repos #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9213c6
to
01a70e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are pulling aarch64
instead of x86_64
, is this right?
No, massive fail, thank you now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use https
for the URL as well, it is available. Can you rebase it all into one commit while you're at it?
Well, it actually is, but it is not listed in any of the instructions. I'm trying to find out why that's not the preferred one.
Squash+merge button appears to be available here, is that not sufficient? |
I really don't like this as it generally produces ugly commit messages. As a contributor, it also makes it more complicated to find out what has been merged because it changes the commit hash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Used for Slurm appliance