Add source packages to ark necessary for Slurm package rebuild #430
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @bertiethorpe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to resolve a critical dependency for Slurm package rebuilds by integrating several new source package repositories into the Ark system. By adding these repositories, the system will gain access to the required source images, thereby enabling successful Slurm package compilation and deployment. The changes primarily involve updating the package-repos configuration to include these new source channels, ensuring that future Slurm-related operations have the necessary foundational components.
Highlights
- Repository Additions: This PR introduces new source package repositories to Ark, specifically for EPEL 8, EPEL 9, Rocky Linux 8.10 (AppStream, BaseOS, Extras), and Rocky Linux 9.6 (AppStream, BaseOS, Extras, CRB).
- Slurm Package Rebuild Support: The primary motivation for these additions is to provide the necessary source images required for rebuilding the Slurm package, addressing a known dependency issue.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds several source package repositories for EPEL and Rocky Linux, which are necessary for rebuilding Slurm packages. The changes are well-structured and consistent with the existing repository definitions. I have one suggestion to add a sync_policy to the EPEL 8 source repository for consistency and to prevent potential synchronization issues, similar to how other EPEL repositories are configured in the file.
|
I realised we've been using |
There used to be some dodgy mirrors, limiting to NL resolved the issue |
|
Interesting |
The slurm package rebuild requires source images, which aren't in Ark.
This PR adds source packages for:
Resolves issue: stackhpc/ansible-slurm-appliance#748