Add Yubikey ssh key - Jasleen

[JasleenKaurSethi]

Add YubiKey security SSH key

[Alex-Welsh]

The CI won't run here because the source branch is from a forked repo outside the StackHPC org. Will need to re-create with a branch inside this repo

[axelsimon]

@Alex-Welsh For my understanding, would the following have been a working worflow?

• create branch in user fork, ie: what Jasleen did, JasleenKaurSethi:Add_securitykey_Jasleen
• pull request from user fork branch to a branch on this repo: into StackHPC:Add_securitykey_Jasleen from JasleenKaurSethi:Add_securitykey_Jasleen
• pull request into StackHPC:master from StackHPC:Add_securitykey_Jasleen
  • CI now runs

Because i've always been told that pulling from a branch on your user fork is the way to do it, for projects that belong to an org ("don't push to main/master", "don't treat the org repo like your own").
Obviously here, we are adding a couple lines to a file, but the good practice should stand i think.

[priteau]

@Alex-Welsh For my understanding, would the following have been a working worflow?

• create branch in user fork, ie: what Jasleen did, JasleenKaurSethi:Add_securitykey_Jasleen

• pull request from user fork branch to a branch on this repo: into StackHPC:Add_securitykey_Jasleen from JasleenKaurSethi:Add_securitykey_Jasleen

• pull request into StackHPC:master from StackHPC:Add_securitykey_Jasleen

  • CI now runs

Because i've always been told that pulling from a branch on your user fork is the way to do it, for projects that belong to an org ("don't push to main/master", "don't treat the org repo like your own"). Obviously here, we are adding a couple lines to a file, but the good practice should stand i think.

I think these practices are for public open source projects, where most contributors would not have push access to the repository. This is a repository for internal use only, it is fine to let every StackHPC member push topic branches to it. Of course, branch protection prevents pushing to main directly.