-
Notifications
You must be signed in to change notification settings - Fork 3
Add run_kayobe_playbook() to support 2025.1 and pre-2025.1 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @seunghun1ee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust solution to maintain compatibility across different Kayobe versions by dynamically adjusting playbook paths. It prevents breaking changes for older deployments while accommodating the new playbook structure introduced in SKC 2025.1, ensuring a smoother upgrade path and consistent operation for users on various Kayobe releases. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new helper function, run_kayobe_playbook, to support different playbook paths for compatibility between SKC 2025.1 and older versions. This is a good approach to maintain backward compatibility. My review includes a suggestion to improve the new function by using local variables, following shell scripting best practices. More importantly, I've highlighted a potential issue where an existence check for an optional playbook was removed, which could cause script failures. I've provided suggestions on how to mitigate this potential regression.
706b9f7 to
49d52d7
Compare
To match the playbook path with SKC 2025.1, PR#98 [1] updated paths of playbooks used by multinode.sh but this broke deployments using SKC 2024.1. Added function run_kayobe_playbook() which conditionally uses new paths if they're detected. [1] #98
49d52d7 to
e4176ab
Compare
To match the playbook path with SKC 2025.1, PR#98 [1] updated paths of playbooks used by multinode.sh but this broke deployments using SKC 2024.1.
Added function run_kayobe_playbook() which conditionally uses new paths if they're detected.
[1] #98