feat: Remove --details flag from server describe

Author: joaopalet

docs/stackit_beta_server_describe.md

@@ -16,18 +16,14 @@ stackit beta server describe [flags]
   Show details of a server with ID "xxx"
   $ stackit beta server describe xxx
 
-  Show detailed information of a server with ID "xxx"
-  $ stackit beta server describe xxx --details
-
   Show details of a server with ID "xxx" in JSON format
   $ stackit beta server describe xxx --output-format json
 ```
 
 ### Options
 
 ```
-      --details   Show detailed information about server
-  -h, --help      Help for "stackit beta server describe"
+  -h, --help   Help for "stackit beta server describe"
 ```
 
 ### Options inherited from parent commands

internal/cmd/beta/server/describe/describe.go

@@ -11,7 +11,6 @@ import (
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/errors"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
-	"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/print"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
@@ -24,13 +23,11 @@ import (
 
 const (
 	serverIdArg = "SERVER_ID"
-	detailsFlag = "details"
 )
 
 type inputModel struct {
 	*globalflags.GlobalFlagModel
 	ServerId string
-	Details  bool
 }
 
 func NewCmd(p *print.Printer) *cobra.Command {
@@ -44,10 +41,6 @@ func NewCmd(p *print.Printer) *cobra.Command {
 				`Show details of a server with ID "xxx"`,
 				"$ stackit beta server describe xxx",
 			),
-			examples.NewExample(
-				`Show detailed information of a server with ID "xxx"`,
-				"$ stackit beta server describe xxx --details",
-			),
 			examples.NewExample(
 				`Show details of a server with ID "xxx" in JSON format`,
 				"$ stackit beta server describe xxx --output-format json",
@@ -76,14 +69,9 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			return outputResult(p, model, resp)
 		},
 	}
-	configureFlags(cmd)
 	return cmd
 }
 
-func configureFlags(cmd *cobra.Command) {
-	cmd.Flags().Bool(detailsFlag, false, "Show detailed information about server")
-}
-
 func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inputModel, error) {
 	serverId := inputArgs[0]
 
@@ -95,7 +83,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
 	model := inputModel{
 		GlobalFlagModel: globalFlags,
 		ServerId:        serverId,
-		Details:         flags.FlagToBoolValue(p, cmd, detailsFlag),
 	}
 
 	if p.IsVerbosityDebug() {
@@ -112,10 +99,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
 
 func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiGetServerRequest {
 	req := apiClient.GetServer(ctx, model.ProjectId, model.ServerId)
-
-	if model.Details {
-		req = req.Details(true)
-	}
+	req = req.Details(true)
 
 	return req
 }
@@ -142,9 +126,8 @@ func outputResult(p *print.Printer, model *inputModel, server *iaas.Server) erro
 		return nil
 	default:
 		table := tables.NewTable()
-		if model.Details {
-			table.SetTitle("Server")
-		}
+		table.SetTitle("Server")
+
 		table.AddRow("ID", *server.Id)
 		table.AddSeparator()
 		table.AddRow("NAME", *server.Name)
@@ -204,11 +187,6 @@ func outputResult(p *print.Printer, model *inputModel, server *iaas.Server) erro
 			return fmt.Errorf("render table: %w", err)
 		}
 
-		// If no --details is set, we only display the overview table
-		if !model.Details {
-			return nil
-		}
-
 		if server.Nics != nil && len(*server.Nics) > 0 {
 			nicsTable := tables.NewTable()
 			nicsTable.SetTitle("Attached Network Interfaces")

internal/cmd/beta/server/describe/describe_test.go

@@ -35,7 +35,6 @@ func fixtureArgValues(mods ...func(argValues []string)) []string {
 func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {
 	flagValues := map[string]string{
 		projectIdFlag: testProjectId,
-		detailsFlag:   "true",
 	}
 	for _, mod := range mods {
 		mod(flagValues)
@@ -50,7 +49,6 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 			Verbosity: globalflags.VerbosityDefault,
 		},
 		ServerId: testServerId,
-		Details:  true,
 	}
 	for _, mod := range mods {
 		mod(model)
@@ -136,17 +134,6 @@ func TestParseInput(t *testing.T) {
 			flagValues:  fixtureFlagValues(),
 			isValid:     false,
 		},
-		{
-			description: "details flag false",
-			argValues:   fixtureArgValues(),
-			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
-				flagValues[detailsFlag] = "false"
-			}),
-			isValid: true,
-			expectedModel: fixtureInputModel(func(model *inputModel) {
-				model.Details = false
-			}),
-		},
 	}
 
 	for _, tt := range tests {