Skip to content

Conversation

@bahkauv70
Copy link
Contributor

Implemented the commands to manage security groups

@joaopalet
Copy link
Contributor

I've focused most of the comments in the create command, but they also apply to other files

@bahkauv70
Copy link
Contributor Author

Applied all suggested changes to other sub commands where appropriate

@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch 3 times, most recently from 3ad022a to 2b1f9a4 Compare December 9, 2024 14:55
@bahkauv70 bahkauv70 requested a review from joaopalet December 9, 2024 15:02
@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch 4 times, most recently from 4cccf13 to 08b1142 Compare December 10, 2024 08:01
@bahkauv70 bahkauv70 requested a review from joaopalet December 10, 2024 08:07
@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch 2 times, most recently from 2364537 to 9b1b2c0 Compare December 10, 2024 08:49
@bahkauv70 bahkauv70 requested a review from joaopalet December 10, 2024 08:54
@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch 4 times, most recently from bb03603 to a6338e3 Compare December 12, 2024 07:51
@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch from 0c7d0bd to e5cbece Compare December 12, 2024 16:02
@vicentepinto98
Copy link
Contributor

Please solve the conflicts first, otherwise you'll need an approval again

@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch from e5cbece to d4ba7e0 Compare December 12, 2024 17:02
@bahkauv70 bahkauv70 force-pushed the feat/670192-security-groups branch from d4ba7e0 to f286095 Compare December 12, 2024 17:11
@bahkauv70 bahkauv70 merged commit 9adbcb1 into main Dec 13, 2024
3 checks passed
@bahkauv70 bahkauv70 deleted the feat/670192-security-groups branch December 13, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants