-
Notifications
You must be signed in to change notification settings - Fork 29
Feat/670192 security groups #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopalet
reviewed
Dec 9, 2024
Contributor
|
I've focused most of the comments in the |
Contributor
Author
|
Applied all suggested changes to other sub commands where appropriate |
3ad022a to
2b1f9a4
Compare
joaopalet
reviewed
Dec 9, 2024
joaopalet
reviewed
Dec 9, 2024
4cccf13 to
08b1142
Compare
joaopalet
reviewed
Dec 10, 2024
2364537 to
9b1b2c0
Compare
bb03603 to
a6338e3
Compare
0c7d0bd to
e5cbece
Compare
Contributor
|
Please solve the conflicts first, otherwise you'll need an approval again |
e5cbece to
d4ba7e0
Compare
d4ba7e0 to
f286095
Compare
vicentepinto98
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the commands to manage security groups