Adjust CLI regarding ske API changes #570
Closed
+9
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function was deprecated on 2024-04-16 and was now removed. Signed-off-by: Alexander Dahmen <[email protected]>
Fyusel
force-pushed
the
fix/remove-ske-getServiceStatusExecute
branch
from
bf7bf7e to
3682103
Compare
Signed-off-by: Alexander Dahmen <[email protected]>
Fyusel
changed the title
bahkauv70
approved these changes
Jan 22, 2025
| TimeWindow: &ske.TimeWindow{ | ||
| End: utils.Ptr("0000-01-01T05:00:00+02:00"), | ||
| Start: utils.Ptr("0000-01-01T03:00:00+02:00"), | ||
| End: utils.Ptr(time.Date(0000, 01, 01, 5, 0, 0, 0, time.UTC)), |
Contributor
There was a problem hiding this comment.
As a matter of personal style I prefer something like this:
func mustDateParse(fmt, val string) time.Time {
time, err := time.Parse(fmt, val)
if err != nil {
log.Panicf("cannot parse %q with format %q: %v", val, fmt, err)
}
return time
}
...
End: utils.Ptr(mustDateParse(time.RFC3339, "0000-01-01T05:00:00+02:00")),
but the current one is totally correct
bahkauv70
previously approved these changes
Jan 22, 2025
Contributor
|
Closing this PR as it has been merged indirectly via renovate PR #573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetServiceStatusExecute was deprecated on 2024-04-16 and was now removed.
ExpiredDate was changed to time instead of string