refactor(cli): pass parameter struct to cmd factories #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-180
Recently all the factories for the subcommands of our CLI accepted a single parameter: a printer. I had the problem that I additionally need to pass the STACKIT CLI version number into all the commands. So I decided to make this refactoring which will allow us to add possibly required additional parameters way easier in the future without having to touch the whole codebase. The parameter struct is passed as a pointer to reduce memory consumption and copy operations.
And this is what the new parameter struct looks like (see
internal/cmd/params/cmd_params.go):Checklist
make fmt- [ ] Examples were added / adjusted (see e.g. here)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)