refactor(cli): add ConvertStringMapToInterfaceMap util function #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceljk
reviewed
Jun 11, 2025
marceljk
reviewed
Jun 11, 2025
marceljk
reviewed
Jun 11, 2025
rubenhoenle
requested changes
Jun 11, 2025
Member
rubenhoenle
left a comment
rubenhoenle
left a comment
There was a problem hiding this comment.
see comments from @marceljk
7 tasks
Benjosh95
force-pushed
the
refactor/cli-203-utility-func-map-conversion
branch
from
201509b to
1e76138
Compare
marceljk
previously approved these changes
Jun 12, 2025
Contributor
marceljk
left a comment
marceljk
left a comment
There was a problem hiding this comment.
Looks good and works well! Can be merged
rubenhoenle
reviewed
Jun 12, 2025
rubenhoenle
previously approved these changes
Jun 12, 2025
rubenhoenle
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Codebase contained multiple implementations of converting
map[string]stringto*map[string]interface{}. This pattern appears in many command files, particularly in the IaaS service commands (volume, backup, network, etc.) when handling label conversions. The code got extracted into util functionConvertStringMapToInterfaceMapand refactored.Jira Ticket: https://jira.schwarz/browse/STACKITCLI-203
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)