Skip to content

Conversation

@rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Aug 28, 2025

Description

also print valid json output when project has no ske clusters

relates to STACKITCLI-240

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

also print valid json output when project has no ske clusters

relates to STACKITCLI-240
@rubenhoenle rubenhoenle self-assigned this Aug 28, 2025
@rubenhoenle rubenhoenle requested a review from a team as a code owner August 28, 2025 13:04
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd 7.41% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list 41.98% (+3.23%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/root.go 7.41% (ø) 108 8 100
github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list/list.go 41.98% (+3.23%) 81 (+1) 34 (+3) 47 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/ske/cluster/list/list_test.go

@rubenhoenle rubenhoenle merged commit a0eee4e into main Aug 29, 2025
5 checks passed
@rubenhoenle rubenhoenle deleted the fix/STACKITCLI-240-ske-list-json-output branch August 29, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants