Fix/handling nullable complex model attributes #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahkauv70
force-pushed
the
fix/handling-nullable-complex-model-attributes
branch
2 times, most recently
from
a7c98d6 to
a089f87
Compare
bahkauv70
force-pushed
the
fix/handling-nullable-complex-model-attributes
branch
from
a089f87 to
cfa1fe8
Compare
vicentepinto98
approved these changes
Dec 5, 2024
bahkauv70
force-pushed
the
fix/handling-nullable-complex-model-attributes
branch
from
cfa1fe8 to
421e5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of complex struct attributes which may be nil as well. Additional
IsNilchecks have been introduced to prevent accidental panics when handling members with a default value.The same issue occured in a few other functions as well, e.g.
HasAtttribute,SetAttributeand so on. This have been fixed as well.Testing this suitable with unit tests is not yet possible with the current state of the generator. This has been discussed with @vicentepinto98 previously and will be added with a different PR (issue not yet created)