Skip to content

Re-add support for nullable fields #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2024
Merged

Re-add support for nullable fields #95

merged 2 commits into from
Oct 11, 2024

Conversation

@vicentepinto98
Copy link
Contributor

@vicentepinto98 vicentepinto98 commented Oct 10, 2024 •
edited
Loading

Reverts #89

  • Tested an SDK generation dry-run and there are no breaking changes
  • Omitempty tag changes for read/writeOnly fields are still applied
  • Tested the usage of a nullable field (networkInterface in UpdatePublicIPPayload and it works as expected

@vicentepinto98 vicentepinto98 changed the title Add support for nullable fields again Re-add support for nullable fields Oct 10, 2024
@vicentepinto98 vicentepinto98 merged commit 2a6689c into main Oct 11, 2024
10 checks passed
@vicentepinto98 vicentepinto98 deleted the revert-89-jp/revert-nullable-utils branch October 11, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joaopalet joaopalet joaopalet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicentepinto98 @joaopalet