feat: add dynamic_routes bool to routing_table #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the optional bool flag "dynamic_routes" to the routing_table resource.
gottliebjo
force-pushed
the
feat/add-dynamic-routes-to-RTs
branch
from
bf34b1c to
16c916a
Compare
marceljk
reviewed
Jan 8, 2026
stackit/internal/services/iaasalpha/routingtable/shared/shared.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/iaasalpha/routingtable/shared/shared.go
Outdated
Show resolved
Hide resolved
stackit/internal/services/iaasalpha/routingtable/table/resource.go
Outdated
Show resolved
Hide resolved
marceljk
previously approved these changes
Jan 9, 2026
rubenhoenle
reviewed
Jan 9, 2026
| resource.TestCheckResourceAttr("data.stackit_routing_table.routing_table", "region", testutil.Region), | ||
| resource.TestCheckNoResourceAttr("data.stackit_routing_table.routing_table", "description"), | ||
| resource.TestCheckResourceAttr("data.stackit_routing_table.routing_table", "system_routes", "true"), | ||
| resource.TestCheckResourceAttr("stackit_routing_table.routing_table", "dynamic_routes", "true"), |
Member
There was a problem hiding this comment.
Suggested change
| resource.TestCheckResourceAttr("stackit_routing_table.routing_table", "dynamic_routes", "true"), | |
| resource.TestCheckResourceAttr("data.stackit_routing_table.routing_table", "dynamic_routes", "true"), |
I guess you want to test the datasource here? Currently you're testing the resource 😄
rubenhoenle
reviewed
Jan 9, 2026
| "dynamic_routes": schema.BoolAttribute{ | ||
| Description: "This controls whether dynamic routes are propagated to this routing table", | ||
| Optional: true, | ||
| Computed: true, |
Member
There was a problem hiding this comment.
Why is it marked as computed? 😅
Author
There was a problem hiding this comment.
If you do not provide a value it is provided by the provider. Same as with system_routes where it is handled the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optional bool flag "dynamic_routes" to the routing_table resource.
Description
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)