Skip to content

Conversation

@marceljk
Copy link
Contributor

Description

relates to #918 and STACKITTPR-300

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk added the do-not-merge Do not merge this right now label Aug 13, 2025
@marceljk
Copy link
Contributor Author

marceljk commented Aug 13, 2025

This is on hold because of some UnmarshalJSON issues in the IaaS service, where a enum has multiple matches in an oneOf schema. (See here)

This issue should be fixed, when stackitcloud/stackit-sdk-generator#182 is merged and the IaaS SDK is updated.

@marceljk marceljk force-pushed the feat/onboard-iaas-project-datasource branch 2 times, most recently from 9c6d19c to 04867b7 Compare August 13, 2025 12:17
@marceljk marceljk marked this pull request as ready for review August 13, 2025 12:17
@marceljk marceljk requested a review from a team as a code owner August 13, 2025 12:17
Fyusel
Fyusel previously approved these changes Aug 14, 2025
@marceljk marceljk force-pushed the feat/onboard-iaas-project-datasource branch from 698e1b6 to e03bd9e Compare August 15, 2025 12:20
@marceljk marceljk removed the do-not-merge Do not merge this right now label Aug 15, 2025
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit 1.92% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/project 46.15% (+46.15%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/project/datasource.go 46.15% (+46.15%) 65 (+65) 30 (+30) 35 (+35) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/provider.go 1.92% (ø) 104 2 102

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/iaas_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/project/datasource_test.go

@marceljk marceljk merged commit 5f1e4ff into main Aug 15, 2025
5 checks passed
@marceljk marceljk deleted the feat/onboard-iaas-project-datasource branch August 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants