Skip to content

Conversation

@lujunsan
Copy link
Contributor

@lujunsan lujunsan commented Sep 8, 2025

Adding updated docs related with the recent thv run --from-config changes

@lujunsan lujunsan requested review from Copilot and danbarr September 8, 2025 13:10
@vercel
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-website Ready Ready Preview Comment Oct 8, 2025 3:55pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation to reflect recent changes to the thv run --from-config command behavior. The changes clarify that using --from-config creates persistent workloads rather than temporary ones, and adds restrictions on flag usage with this option.

Key changes:

  • Updated behavior description for --from-config to emphasize persistent workload creation
  • Added restriction that --from-config cannot be used with other flags
  • Enhanced explanations across CLI reference and user guide documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/toolhive/reference/cli/thv_run.md Added details about persistent workload creation and flag restrictions for --from-config
docs/toolhive/reference/cli/thv_export.md Updated description to clarify exported configs create persistent, manageable workloads
docs/toolhive/guides-cli/run-mcp-servers.mdx Enhanced explanation of --from-config behavior and added note about flag restrictions

Signed-off-by: lujunsan <[email protected]>
Copy link
Collaborator

@danbarr danbarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lujunsan the reference/cli docs will get copied over via an automated PR when the next release gets cut. You might want to drop your changes from this PR to avoid a potential conflict?

the original server used secrets, you must have the same secrets available in
your ToolHive secrets store.
This creates a persistent server instance with identical settings to the
original and saves a real configuration file. The server can be stopped,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "and saves a real configuration" file means here. If you mean the runconfig, I think that's a bit of an internal plumbing thing that the user doesn't really need to know/care about?

Copy link
Collaborator

@danbarr danbarr Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lujunsan just wanted to make sure you saw this question and the comment above about the auto-update of the cli reference docs? Anything you need from me to help clarify this?

@danbarr danbarr merged commit d7e546f into main Oct 8, 2025
7 checks passed
@danbarr danbarr deleted the update-from-config-docs branch October 8, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants