-
Notifications
You must be signed in to change notification settings - Fork 2
add an example about accessing internal workloads #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is specifically for accessing containers on the same network when running network isolation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add similar to the CLI guide, docs/toolhive/guides-cli/network-isolation.mdx
Co-authored-by: Dan Barr <[email protected]>
Co-authored-by: Dan Barr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation to help users understand how to configure network isolation to access internal workloads running on the same network. This is particularly useful for development scenarios where MCP servers need to communicate with local databases, APIs, or other services.
Key changes:
- Added a new section explaining how to access other workloads on the same network
- Provided a practical Docker example using
host.docker.internal
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two suggestions that will fix the formatting for CI, also just normalizing the text between the two guides.
Co-authored-by: Dan Barr <[email protected]>
Co-authored-by: Dan Barr <[email protected]>
This is specifically for accessing containers on the same network when running network isolation
Description
Add an example about how to enable access to internal workloads on the same network
Related issues/PRs
https://stacklok.slack.com/archives/C08JYS26TV3/p1758776181092359
Screenshots
Merge checklist
Content
sidebars.ts) updated for added, deleted, reordered, or renamed filesvercel.jsonfor moved, renamed, or deleted pages (i.e., if the URL slug changed)Reviews