Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Sep 29, 2025

This is specifically for accessing containers on the same network when running network isolation

Description

Add an example about how to enable access to internal workloads on the same network

Related issues/PRs

https://stacklok.slack.com/archives/C08JYS26TV3/p1758776181092359

Screenshots

Merge checklist

Content

  • New pages include a frontmatter section with title and description at a minimum
  • Sidebar navigation (sidebars.ts) updated for added, deleted, reordered, or renamed files
  • Redirects added to vercel.json for moved, renamed, or deleted pages (i.e., if the URL slug changed)

Reviews

  • Content has been reviewed for technical accuracy
  • Content has been reviewed for spelling, grammar, and style

This is specifically for accessing containers on the same network
when running network isolation
Copilot AI review requested due to automatic review settings September 29, 2025 07:35
@vercel
Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-website Ready Ready Preview Comment Oct 1, 2025 8:28am

@yrobla yrobla requested review from danbarr and removed request for Copilot September 29, 2025 07:36
Copy link
Collaborator

@danbarr danbarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add similar to the CLI guide, docs/toolhive/guides-cli/network-isolation.mdx

@yrobla yrobla requested a review from danbarr September 30, 2025 07:39
Copilot AI review requested due to automatic review settings September 30, 2025 09:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation to help users understand how to configure network isolation to access internal workloads running on the same network. This is particularly useful for development scenarios where MCP servers need to communicate with local databases, APIs, or other services.

Key changes:

  • Added a new section explaining how to access other workloads on the same network
  • Provided a practical Docker example using host.docker.internal

@yrobla
Copy link
Contributor Author

yrobla commented Sep 30, 2025

I think we should add similar to the CLI guide, docs/toolhive/guides-cli/network-isolation.mdx

done

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copy link
Collaborator

@danbarr danbarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions that will fix the formatting for CI, also just normalizing the text between the two guides.

@yrobla yrobla merged commit 4b6524e into main Oct 1, 2025
6 checks passed
@yrobla yrobla deleted the add-network-isolation-examples branch October 1, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants