Remove permissionProfile from K8s examples #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Barr <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes unimplemented permissionProfile configuration from all Kubernetes examples in the ToolHive documentation and updates related content. The permissionProfile feature is not implemented in the ToolHive Operator, and since it's optional, removing it from examples prevents user confusion.
Key changes:
- Removes
permissionProfileconfiguration blocks from all K8s manifest examples - Removes documentation section about network isolation roadmap feature
- Updates troubleshooting references from "permission profile" to "RBAC permissions"
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/toolhive/tutorials/vault-integration.mdx | Removes permissionProfile from GitHub MCP server example |
| docs/toolhive/guides-mcp/playwright.mdx | Removes permissionProfile from three Playwright server examples |
| docs/toolhive/guides-mcp/osv.mdx | Removes permissionProfile from OSV scanner example |
| docs/toolhive/guides-mcp/k8s.mdx | Removes permissionProfile from Kubernetes MCP server example |
| docs/toolhive/guides-mcp/github.mdx | Removes permissionProfile from GitHub MCP server example |
| docs/toolhive/guides-mcp/filesystem.mdx | Removes permissionProfile with inline comment from filesystem example |
| docs/toolhive/guides-mcp/fetch.mdx | Removes permissionProfile from fetch server example |
| docs/toolhive/guides-mcp/context7.mdx | Removes permissionProfile from two Context7 examples |
| docs/toolhive/guides-k8s/run-mcp-k8s.mdx | Removes permissionProfile from multiple examples and related documentation sections |
| docs/toolhive/guides-cli/build-containers.mdx | Removes permissionProfile from container build example |
ChrisJBurns
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
permissionProfilefrom all the K8s examples. It's not implemented, and since it's optional there's no need to have it there.Also removes the note about network isolation/permissions in K8s being a roadmap item; this isn't confirmed. For now, users should use their existing K8s network policy tools.
Merge checklist
Content
sidebars.ts) updated for added, deleted, reordered, or renamed filesvercel.jsonfor moved, renamed, or deleted pages (i.e., if the URL slug changed)Reviews
Signed-off-by: Dan Barr [email protected]