feat(main): trying to always kill thv process

[samuv]

Ensures the ToolHive child process always gets cleaned up when the app exits, no matter how it quits. We've added multiple layers of protection to catch every exit scenario:

• app event handlers (quit, will-quit) - normal user quits
• Windows session-end handler on BrowserWindow - catches Windows shutdown/restart/logout (where normal quit events don't fire!)
• process handlers (exit, SIGTERM, SIGINT) - force kills and Docker stops
• Enhanced stopToolhive() - tries graceful SIGTERM first, then force SIGKILL after 2s timeout
• spawn options - detached: false + windowsHide: true so Windows job objects auto-kill child processes

I tried multiple way including the upgrade, and it seems consistent

I hope the quit and exit callbacks will cover what we were missing

[Copilot]

Pull Request Overview

This PR enhances the cleanup of the ToolHive child process to ensure it's always terminated when the application exits, regardless of the exit scenario. The changes add multiple layers of protection across different exit paths and improve the graceful shutdown process.

Key changes:

• Enhanced stopToolhive() with graceful termination (SIGTERM) followed by forced kill (SIGKILL) after 2s timeout
• Added windowsHide: true spawn option to leverage Windows job objects for automatic child process cleanup
• Implemented comprehensive exit handlers: quit, session-end (Windows-specific), exit, SIGTERM, and SIGINT

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
main/src/toolhive-manager.ts	Enhanced process spawning with Windows job object support and improved stopToolhive() with graceful-then-forced termination
main/src/main.ts	Added multiple exit event handlers for comprehensive cleanup coverage across different quit scenarios

[Copilot]

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[peppescg]

🔧