Skip to content

Commit 1ef0fc3

Browse files
yroblataskbot
andauthored
changes from review (#855)
Co-authored-by: taskbot <[email protected]>
1 parent 728c77a commit 1ef0fc3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/container/docker/client.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ func (c *Client) createMcpContainer(ctx context.Context, name string, networkNam
266266
// Create host configuration
267267
hostConfig := &container.HostConfig{
268268
Mounts: convertMounts(permissionConfig.Mounts),
269-
NetworkMode: "",
269+
NetworkMode: container.NetworkMode(permissionConfig.NetworkMode),
270270
CapAdd: permissionConfig.CapAdd,
271271
CapDrop: permissionConfig.CapDrop,
272272
SecurityOpt: permissionConfig.SecurityOpt,
@@ -955,7 +955,7 @@ func (c *Client) getPermissionConfigFromProfile(
955955
// Start with a default permission config
956956
config := &runtime.PermissionConfig{
957957
Mounts: []runtime.Mount{},
958-
NetworkMode: "none",
958+
NetworkMode: "", // set to blank as podman is not recognizing the "none" value when we attach to other networks
959959
CapDrop: []string{"ALL"},
960960
CapAdd: []string{},
961961
SecurityOpt: []string{},

0 commit comments

Comments
 (0)