Skip to content

Commit 728c77a

Browse files
yroblataskbot
andauthored
fix: do not pass network mode in host, as we rely on network (#854)
Co-authored-by: taskbot <[email protected]>
1 parent f23cdc0 commit 728c77a

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

pkg/container/docker/client.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ func (c *Client) createMcpContainer(ctx context.Context, name string, networkNam
266266
// Create host configuration
267267
hostConfig := &container.HostConfig{
268268
Mounts: convertMounts(permissionConfig.Mounts),
269-
NetworkMode: container.NetworkMode(permissionConfig.NetworkMode),
269+
NetworkMode: "",
270270
CapAdd: permissionConfig.CapAdd,
271271
CapDrop: permissionConfig.CapDrop,
272272
SecurityOpt: permissionConfig.SecurityOpt,
@@ -292,12 +292,15 @@ func (c *Client) createMcpContainer(ctx context.Context, name string, networkNam
292292
// create mcp container
293293
internalEndpointsConfig := map[string]*network.EndpointSettings{}
294294
if isolateNetwork {
295-
internalEndpointsConfig[networkName] = &network.EndpointSettings{}
295+
internalEndpointsConfig[networkName] = &network.EndpointSettings{
296+
NetworkID: networkName,
297+
}
296298
} else {
297299
// for other workloads such as inspector, add to external network
298-
internalEndpointsConfig["toolhive-external"] = &network.EndpointSettings{}
300+
internalEndpointsConfig["toolhive-external"] = &network.EndpointSettings{
301+
NetworkID: "toolhive-external",
302+
}
299303
}
300-
301304
containerId, err := c.createContainer(ctx, name, config, hostConfig, internalEndpointsConfig)
302305
if err != nil {
303306
return "", fmt.Errorf("failed to create container: %v", err)

0 commit comments

Comments
 (0)