feat: enhance thv mcp list to accept server names in addition to URLs #1488
+67
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
feat/mcp-list-server-names
branch
from
6e8b685 to
a78c8b3
Compare
- Modified --server flag to accept both URLs and server names from running workloads - Added resolveServerURL function to look up running servers by name - Uses efficient GetWorkload method instead of listing all workloads - Improved error messages for better user experience - Removed unnecessary logger calls that could corrupt JSON output This allows users to conveniently reference MCP servers by their friendly names (e.g., 'thv mcp list --server fetch') instead of having to remember or look up their URLs, while maintaining backward compatibility with direct URL usage. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
feat/mcp-list-server-names
branch
from
a78c8b3 to
3723b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
thv mcp listcommand to accept both server URLs and server names from running workloads via the--serverflag.Changes
--serverflag to accept both URLs and server names from running workloadsresolveServerURLfunction to look up running servers by name using the efficientGetWorkloadmethodBenefits
This allows users to conveniently reference MCP servers by their friendly names instead of having to remember or look up their URLs, while maintaining backward compatibility with direct URL usage.
Examples
Using server name:
Using URL (backward compatible):
Testing
./bin/thv mcp list tools --server fetch./bin/thv mcp list tools --server http://127.0.0.1:29104/mcpFixes the issue discussed where users wanted to use server names instead of URLs for the
--serverflag.