Fix: Added path configuration to registry server #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Martinoli <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2794 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 319 319
Lines 30882 30885 +3
=======================================
+ Hits 17433 17436 +3
Misses 11950 11950
Partials 1499 1499 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
approved these changes
Nov 28, 2025
| return nil, fmt.Errorf("git repository is required") | ||
| } | ||
|
|
||
| if git.Path == "" { |
Contributor
There was a problem hiding this comment.
Wouldn't it be easier to validate at the CRD level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git configuration was losing the
pathdefinition when passed to the registry server.