Skip to content

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Nov 28, 2025

No description provided.

@yrobla yrobla requested a review from Copilot November 28, 2025 16:17
@github-actions github-actions bot added the size/S Small PR: 100-299 lines changed label Nov 28, 2025
Copilot finished reviewing on behalf of yrobla November 28, 2025 16:19
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.46%. Comparing base (c73c5ef) to head (e36cf57).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2798      +/-   ##
==========================================
- Coverage   56.48%   56.46%   -0.02%     
==========================================
  Files         319      319              
  Lines       30943    30939       -4     
==========================================
- Hits        17479    17471       -8     
- Misses      11960    11963       +3     
- Partials     1504     1505       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the Virtual MCP server authentication configuration by removing the "mixed" mode for outgoing authentication, leaving only "inline" and "discovered" modes. This change reduces complexity in the authentication source logic and makes the codebase easier to understand and maintain.

Key Changes

  • Removed "mixed" authentication source mode from configuration validation and implementation
  • Updated documentation comments to reflect only "inline" and "discovered" modes
  • Removed three test cases that were specific to "mixed" mode behavior

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/vmcp/config/validator.go Removed "mixed" from valid sources list in outgoing auth validation
pkg/vmcp/config/config.go Updated documentation comment to remove "mixed" mode reference
pkg/vmcp/aggregator/discoverer_test.go Removed 3 test cases testing mixed mode behavior
pkg/vmcp/aggregator/discoverer.go Removed mixed mode case from auth resolution logic and updated comments
cmd/thv-operator/controllers/virtualmcpserver_vmcpconfig_test.go Changed test from "mixed" to "discovered" mode
cmd/thv-operator/api/v1alpha1/virtualmcpserver_webhook_test.go Updated error message to reflect removed "mixed" mode
cmd/thv-operator/api/v1alpha1/virtualmcpserver_webhook.go Removed "mixed" from valid sources map and updated error message
cmd/thv-operator/api/v1alpha1/virtualmcpserver_types.go Removed "mixed" from kubebuilder enum validation and updated comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Nov 28, 2025
@yrobla yrobla force-pushed the fix/remove_mixed_mode branch from cca2ada to e36cf57 Compare November 28, 2025 16:34
@github-actions github-actions bot added size/S Small PR: 100-299 lines changed and removed size/S Small PR: 100-299 lines changed labels Nov 28, 2025
@yrobla yrobla requested review from JAORMX, Copilot and jhrozek November 28, 2025 16:35
Copilot finished reviewing on behalf of yrobla November 28, 2025 16:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Small PR: 100-299 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants