-
Notifications
You must be signed in to change notification settings - Fork 149
remove mixed mode to simplify vmcp operation #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
==========================================
- Coverage 56.48% 56.46% -0.02%
==========================================
Files 319 319
Lines 30943 30939 -4
==========================================
- Hits 17479 17471 -8
- Misses 11960 11963 +3
- Partials 1504 1505 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR simplifies the Virtual MCP server authentication configuration by removing the "mixed" mode for outgoing authentication, leaving only "inline" and "discovered" modes. This change reduces complexity in the authentication source logic and makes the codebase easier to understand and maintain.
Key Changes
- Removed "mixed" authentication source mode from configuration validation and implementation
- Updated documentation comments to reflect only "inline" and "discovered" modes
- Removed three test cases that were specific to "mixed" mode behavior
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/vmcp/config/validator.go |
Removed "mixed" from valid sources list in outgoing auth validation |
pkg/vmcp/config/config.go |
Updated documentation comment to remove "mixed" mode reference |
pkg/vmcp/aggregator/discoverer_test.go |
Removed 3 test cases testing mixed mode behavior |
pkg/vmcp/aggregator/discoverer.go |
Removed mixed mode case from auth resolution logic and updated comments |
cmd/thv-operator/controllers/virtualmcpserver_vmcpconfig_test.go |
Changed test from "mixed" to "discovered" mode |
cmd/thv-operator/api/v1alpha1/virtualmcpserver_webhook_test.go |
Updated error message to reflect removed "mixed" mode |
cmd/thv-operator/api/v1alpha1/virtualmcpserver_webhook.go |
Removed "mixed" from valid sources map and updated error message |
cmd/thv-operator/api/v1alpha1/virtualmcpserver_types.go |
Removed "mixed" from kubebuilder enum validation and updated comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…oolhive into fix/remove_mixed_mode
cca2ada to
e36cf57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.