[feat] Enhance NewForm and useNewForm with event type utilities, date validation, and backend integration#55
Merged
otc-zuul[bot] merged 8 commits intomainfrom Jan 17, 2025
Merged
Conversation
…ration and loading state
Implements functions to retrieve event types based on impact values and vice versa. Enhances code maintainability and readability by centralizing event type logic.
…prove date validation logic
…tial missing incident IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This pull request introduces several improvements and new features to the NewForm component and the useNewForm hook, focusing on enhancing functionality, user experience, and maintainability. The changes include the following:
Key Changes:
Loading State for Submission
Backend Integration for Event Submission
Event Type and Impact Utility Functions
Refactor Event Type Determination
GetEventTypeutility function for cleaner and more consistent event type determination.Date Formatting and Localization
dayjsfor datetime formatting.Enhanced Date Validation Logic