[pull] master from rmosolgo:master #189
Open
+203,336
−30,587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo
force-pushed
the
master
branch
3 times, most recently
from
9ebb8e0 to
3df9181
Compare
Add GraphQL::Query::Partial
Fix fiber-storage in gemspec
Add test for lazy-defined connection type in class
[INVALID_NUMBER_FOLLOWED_BY_NAME_REGEXP] Don't add whitespace when vars include numbers
Claude Code helped to optimize this potentially slow regexp depending on the document. Specifically, the backtracking in the original regexp was the main performance issue. This does a few things: 1. adds a very simple and faster pre-check to gate if the main regexp should even run 2. prevents as much backtracking as possible Benchmarks: | Document Type | Before | After | Speedup | |--------------------------------|--------|--------|---------| | Typical large (125KB) | 0.72s | 0.06s | 12x | | Colon-heavy (35KB) | 0.24s | 0.007s | 34x | | Pathological worst-case (26KB) | 1.64s | 0.25s | 6.6x | | No digits (17KB) | 0.10s | 0.002s | 54x |
…ed-by-name-regexp Optimize INVALID_NUMBER_FOLLOWED_BY_NAME_REGEXP
Remove Field.from_options to reduce memory usage
Improve documentation for `field` and `argument` DSL methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )