ROX-27130: Reconcile operators using ArgoCD#2195
Conversation
ludydoo
had a problem deploying
to
development
GitHub Actions
Failure
ludydoo
force-pushed
the
ROX-27130-operators-on-argocd
branch
from
fef372d to
d98821b
Compare
ludydoo
had a problem deploying
to
development
GitHub Actions
Failure
| securedClusterReconcilerEnabled: false | ||
| verticalPodAutoscaling: | ||
| recommenders: [] | ||
| applications: |
There was a problem hiding this comment.
Why should we define apps in fleet-manager?
How about adding these apps to the bootstrap app?
We can target the HEAD revision and have kustomizations/helm values for each cluster if we want changes to the gitops config to take effect immediately.
UPD: But most likely we don't want that for operators, do we?
There was a problem hiding this comment.
Yeah having all manifests in the acscs-manifests would be the end-goal, but it was a bit too radical for a single PR lol. Also, we'll need to remove the e2e-upgrade-tests suite altogether when we do
| @@ -0,0 +1,163 @@ | |||
| package argox | |||
There was a problem hiding this comment.
Is it like argo + rox ? :)
There was a problem hiding this comment.
lol. I meant argo + extensions
kovayur
left a comment
kovayur
left a comment
There was a problem hiding this comment.
Label selector must be changed, otherwise it doesn't match the default rollout group
| } | ||
| if want.Labels == nil { | ||
| want.Labels = map[string]string{} | ||
| if err := argox.ReconcileApplication(ctx, r.client, want); err != nil { |
|
/retest |
| } | ||
|
|
||
| // Ensuring the desired applications have labels matching the existingStateSelector | ||
| for k, v := range existingStateSelector { |
There was a problem hiding this comment.
This is plenty clear as it is but as FYI: https://pkg.go.dev/maps#Copy
IMHO it should really be called "Upsert" or "Update"
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebensh, kovayur, kurlov, ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Description
This PR moves the reconciliation of RHACS operators to ArgoCD.
It introduces a new top-level field in the "Gitops Config" called "Applications". Those are ArgoCD applications that Fleetshard-Sync will manage.
Adds validation for the "applications" field
It removes the
rhacs_operatorsfield from the Gitops configurationIt removes the
fleetshard_sync_operator_health_status_imagesmetric, which is not used anywhere.SOPs will be modified once this is merged
GitOps config to be updated
Checklist (Definition of Done)
Test manualROX-12345: ...Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryRDS changes were e2e tested manuallyCheck AWS limits are reasonable for changes provisioning new resources(If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environmentTest manual
make deploy/bootstrap deploy/dev