Skip to content

ROX-13466: return unauthorized when deleting central in org but not owned#2432

Merged
johannes94 merged 1 commit intomainfrom
jmalsam/ROX-13466
Sep 10, 2025
Merged

ROX-13466: return unauthorized when deleting central in org but not owned#2432
johannes94 merged 1 commit intomainfrom
jmalsam/ROX-13466

Conversation

@johannes94
Copy link
Copy Markdown
Contributor

@johannes94 johannes94 commented Sep 10, 2025

Description

Users in a RH Org can see all Centrals in their Org, if they try to delete one not owned by them and they are not system or organization admin they currently get 404 errors, which does not make sense since they are allowed to see the central.

This PR changes the code so that it returns 403 in those cases.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johannes94 johannes94 merged commit 6a09aa8 into main Sep 10, 2025
19 checks passed
@johannes94 johannes94 deleted the jmalsam/ROX-13466 branch September 10, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants