Bump to go1.24 and upgrade argocd to 2.14.17#2433
Merged
Conversation
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
changed the title
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
- Add version: 2 specification required for v2 - Remove deprecated run.checks field - Update staticcheck settings to include both SA and ST rules - Remove gofmt and goimports (now formatters, not linters) - Remove gosimple and stylecheck (now part of staticcheck) - Update pre-commit hook to use golangci-lint v2.4.0 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
kurlov
had a problem deploying
to
development
GitHub Actions
Failure
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Member
Author
|
/retest |
kovayur
reviewed
Sep 22, 2025
| module github.com/stackrox/acs-fleet-manager | ||
|
|
||
| go 1.23.0 | ||
| go 1.24.6 |
Contributor
There was a problem hiding this comment.
Better to specify the lowest possible Go version, to be able to run on the lower patch versions, unless you rely on a bug fix that is introduced in 1.24.6
Suggested change
| go 1.24.6 | |
| go 1.24.0 |
Member
Author
There was a problem hiding this comment.
Unfortunately, 1.24.6 is the lowest possible.The argo-cd dep requires it:
$ go mod tidy
go: github.com/argoproj/argo-cd/v2@v2.14.16 requires go >= 1.24.6; switching to go1.24.7
kovayur
reviewed
Sep 22, 2025
tools/go.mod
Outdated
| module github.com/stackrox/acs-fleet-manager/tools | ||
|
|
||
| go 1.23.0 | ||
| go 1.24 |
Contributor
There was a problem hiding this comment.
It is preferable to use stricter semantics, introduced in Go 1.21.
Suggested change
| go 1.24 | |
| go 1.24.0 |
Member
Author
There was a problem hiding this comment.
I set it to 1.24.6 to be consistent with the root go.mod
kovayur
reviewed
Sep 22, 2025
.openshift-ci/e2e-runtime/Dockerfile
Outdated
| RUN dnf update -y --disablerepo=\* --enablerepo=baseos,appstream && dnf -y install procps make which git gettext jq gcc && dnf clean all && rm -rf /var/cache/dnf | ||
|
|
||
| COPY --from=registry.ci.openshift.org/openshift/release:golang-1.23 /usr/lib/golang /usr/lib/golang | ||
| COPY --from=registry.redhat.io/rhel8/go-toolset@sha256:4842bf7e31849a442f4c6d00f00fe3a6d4793525764e0ddb3ba098c6649a7f67 /usr/lib/golang /usr/lib/golang |
Contributor
There was a problem hiding this comment.
Inconsistent with other Dockerfiles (tags vs sha)
kovayur
reviewed
Sep 22, 2025
| args: ["--baseline", ".secrets.baseline"] | ||
| - repo: https://github.com/golangci/golangci-lint | ||
| rev: v1.64.8 | ||
| rev: v2.4.0 |
kovayur
approved these changes
Sep 22, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
New changes are detected. LGTM label has been removed. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
N/A