Skip to content

ROX-33584: Add glog verbosity setting to fleetshard-sync#2623

Merged
kovayur merged 1 commit intomainfrom
yury/add-klog-verbose
Mar 13, 2026
Merged

ROX-33584: Add glog verbosity setting to fleetshard-sync#2623
kovayur merged 1 commit intomainfrom
yury/add-klog-verbose

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Mar 12, 2026

Description

  • add verbosity setting (GLOG_V env var) to FSS to enable the verbose mode for debugging.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur requested a review from kurlov March 12, 2026 12:27
@kovayur kovayur requested a review from johannes94 March 12, 2026 12:28
@kovayur kovayur changed the title ROX-33584: Forward client-go logs to glog in fleetshard-sync ROX-33584: Add glog verbosity setting to fleetshard-sync Mar 12, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit fec493c into main Mar 13, 2026
18 checks passed
@kovayur kovayur deleted the yury/add-klog-verbose branch March 13, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants