Skip to content

ROX-33817: Bump stackrox/stackrox to 4.10.0#2645

Merged
kovayur merged 2 commits intomainfrom
yury/bump-acs-4-10
Mar 27, 2026
Merged

ROX-33817: Bump stackrox/stackrox to 4.10.0#2645
kovayur merged 2 commits intomainfrom
yury/bump-acs-4-10

Conversation

@kovayur
Copy link
Contributor

@kovayur kovayur commented Mar 25, 2026

Description

Update golang dependency and the runtime operator version (dev,e2e)

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur force-pushed the yury/bump-acs-4-10 branch from 7be09b9 to 621e1c4 Compare March 25, 2026 16:30
@kovayur kovayur changed the title chore(deps): Bump stackrox/stackrox to 4.10.0 ROX-33817: Bump stackrox/stackrox to 4.10.0 Mar 26, 2026
Copy link
Contributor

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

// Telemeter is a wrapper interface for the telemeter interface to enable mock testing.
//
//go:generate moq -out telemetry_moq.go . Telemeter
type Telemeter interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reuse the mocks from central's pkg/telemetry/phonehome/telemeter/mocks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to mix 2 mocking libraries in acs-fleet-manager


import (
"context"
"github.com/stackrox/rox/pkg/telemetry/phonehome/telemeter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the imports are not properly ordered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's autogenerated 🤷

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johannes94, kovayur, parametalol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Mar 27, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2026

New changes are detected. LGTM label has been removed.

@kovayur kovayur deployed to development March 27, 2026 15:00 — with GitHub Actions Active
@kovayur kovayur merged commit c884d6a into main Mar 27, 2026
18 checks passed
@kovayur kovayur deleted the yury/bump-acs-4-10 branch March 27, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants