Conversation
Latest actionlint needs golang 1.25, which comes with fedora 42.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3178 +/- ##
=======================================
Coverage 27.38% 27.38%
=======================================
Files 95 95
Lines 5427 5427
Branches 2548 2548
=======================================
Hits 1486 1486
Misses 3214 3214
Partials 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Molter73
left a comment
There was a problem hiding this comment.
Should we bump to 43 instead? 44 launched as beta a couple weeks ago and the full release is scheduled to happen in a couple of weeks, 42 will go out of support shortly after that.
https://fedoramagazine.org/announcing-fedora-linux-44-beta/
Alternatively, we could look at something more stable like CentOS Stream 10, which should fairly new packages.
|
I considered 42 as the minimal shift needed to get go 1.25, but yeah, if it will go out of support soon, let's switch to 43. |
4737b57 to
451d08d
Compare
|
/retest collector-on-push |
ovalenti
left a comment
There was a problem hiding this comment.
We might want to update the title of the PR. I made a small comment, but I think it's fine.
| dnf config-manager --set-enabled crb -y && \ | ||
| dnf install epel-release -y && \ |
There was a problem hiding this comment.
[nit] I was wondering about the -y flag at the end of the command instead of after install as we usually do.
Looking at the documentation, it looks like the expected location of -y is right after dnf ([GLOBAL OPTIONS]). So we never do it right... It works that way, so it's probably fine.
Description
Latest actionlint needs golang 1.25, which comes with fedora 42.
Testing Performed
CI is sufficient.