Skip to content

Bump fedora version to 42#3178

Open
erthalion wants to merge 2 commits intomasterfrom
ci/bump-linter-fedora-42
Open

Bump fedora version to 42#3178
erthalion wants to merge 2 commits intomasterfrom
ci/bump-linter-fedora-42

Conversation

@erthalion
Copy link
Copy Markdown
Contributor

Description

Latest actionlint needs golang 1.25, which comes with fedora 42.

Testing Performed

CI is sufficient.

Latest actionlint needs golang 1.25, which comes with fedora 42.
@erthalion erthalion requested a review from a team as a code owner April 1, 2026 15:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.38%. Comparing base (c8c0181) to head (451d08d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3178   +/-   ##
=======================================
  Coverage   27.38%   27.38%           
=======================================
  Files          95       95           
  Lines        5427     5427           
  Branches     2548     2548           
=======================================
  Hits         1486     1486           
  Misses       3214     3214           
  Partials      727      727           
Flag Coverage Δ
collector-unit-tests 27.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ovalenti
ovalenti previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump to 43 instead? 44 launched as beta a couple weeks ago and the full release is scheduled to happen in a couple of weeks, 42 will go out of support shortly after that.

https://fedoramagazine.org/announcing-fedora-linux-44-beta/

Alternatively, we could look at something more stable like CentOS Stream 10, which should fairly new packages.

@erthalion
Copy link
Copy Markdown
Contributor Author

I considered 42 as the minimal shift needed to get go 1.25, but yeah, if it will go out of support soon, let's switch to 43.

@ovalenti ovalenti dismissed their stale review April 1, 2026 16:18

Strategy change

@erthalion erthalion force-pushed the ci/bump-linter-fedora-42 branch from 4737b57 to 451d08d Compare April 2, 2026 13:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

/retest collector-on-push

Copy link
Copy Markdown
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to update the title of the PR. I made a small comment, but I think it's fine.

Comment on lines +13 to +14
dnf config-manager --set-enabled crb -y && \
dnf install epel-release -y && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] I was wondering about the -y flag at the end of the command instead of after install as we usually do.

Looking at the documentation, it looks like the expected location of -y is right after dnf ([GLOBAL OPTIONS]). So we never do it right... It works that way, so it's probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants