Skip to content

Bump go to 1.23.6#223

Merged
janisz merged 2 commits intomainfrom
Bump-go-to-1.23.6
Mar 4, 2025
Merged

Bump go to 1.23.6#223
janisz merged 2 commits intomainfrom
Bump-go-to-1.23.6

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Feb 27, 2025

@janisz janisz requested a review from BradLugo February 27, 2025 14:10
Copy link
Copy Markdown
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update scanner-build, too?

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 3, 2025

@RTann Done. I was not aware that scanner in stackrox uses different image

@janisz janisz requested a review from RTann March 3, 2025 16:38
Copy link
Copy Markdown
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, so approving, though @BradLugo would know more about what else would need to happen to make sure we can do this upstream/downstream. Seems like it's available downstream, so I do not believe there are any blockers

@BradLugo
Copy link
Copy Markdown
Contributor

BradLugo commented Mar 3, 2025

Other changes that would be nice for upstream: updating stackrox-ui-test.Dockerfile and getting the new images mirrored in OSCI. However, I don't think these are required (they're nice-to-haves, mostly for consistency).

For downstream, I see it's available as well, and our downstream pipelines should get the latest builders, i.e., we shouldn't need to do anything downstream.

@janisz janisz merged commit 3a5d1ce into main Mar 4, 2025
7 checks passed
@janisz janisz deleted the Bump-go-to-1.23.6 branch March 4, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants