Skip to content

Conversation

erthalion
Copy link
Contributor

Description

Allow to spin up Fact 1 as part of Collector DaemonSet

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Not validated yet.

Copy link

openshift-ci bot commented Sep 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@erthalion erthalion changed the title Add Fact behind a feature flag ROX-30729: Add Fact behind a feature flag Sep 2, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 2, 2025

Images are ready for the commit at 058a82f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-649-g058a82f390.

Allow to spin up Fact [1] as part of Collector DaemonSet

[1]: https://github.com/stackrox/fact/
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.12%. Comparing base (34117b8) to head (058a82f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #16627       +/-   ##
===========================================
- Coverage   48.73%   48.12%    -0.61%     
===========================================
  Files        2658      768     -1890     
  Lines      198307    78541   -119766     
===========================================
- Hits        96635    37799    -58836     
+ Misses      94106    37309    -56797     
+ Partials     7566     3433     -4133     
Flag Coverage Δ
go-unit-tests 48.12% <ø> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants