Skip to content

Conversation

erthalion
Copy link
Contributor

Description

Allow to spin up Fact 1 as part of Collector DaemonSet

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Not validated yet.

Copy link

openshift-ci bot commented Sep 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@erthalion erthalion changed the title Add Fact behind a feature flag ROX-30729: Add Fact behind a feature flag Sep 2, 2025
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 2, 2025

Images are ready for the commit at c04d1b3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-660-gc04d1b3fab.

Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.98%. Comparing base (8fd05ff) to head (c04d1b3).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #16627       +/-   ##
===========================================
- Coverage   48.65%   47.98%    -0.67%     
===========================================
  Files        2662      768     -1894     
  Lines      199044    79004   -120040     
===========================================
- Hits        96841    37910    -58931     
+ Misses      94615    37643    -56972     
+ Partials     7588     3451     -4137     
Flag Coverage Δ
go-unit-tests 47.98% <ø> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erthalion erthalion force-pushed the feature/fact-helm branch 2 times, most recently from d69d837 to cd6ba50 Compare September 3, 2025 13:06
Allow to spin up Fact [1] as part of Collector DaemonSet

[1]: https://github.com/stackrox/fact/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants