Skip to content

Conversation

@sachaudh
Copy link
Contributor

@sachaudh sachaudh commented Dec 2, 2025

Description

This PR fixes styling issues related to the "Share Feedback Modal".

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Before v5

Screenshot 2025-12-01 at 7 21 31 PM

After v5 but before PR fixes

Screenshot 2025-12-01 at 7 22 44 PM

After PR fixes

Screenshot 2025-12-01 at 7 17 37 PM

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sachaudh sachaudh force-pushed the saif/ROX-31770-fix-share-feedback-modal branch from 1963578 to b0361e7 Compare December 2, 2025 03:35
@sachaudh sachaudh changed the base branch from dv/ROX-31766-fix-logos-and-login-page to saif/ROX-31771-fix-my-profile December 2, 2025 03:35
@sachaudh sachaudh marked this pull request as ready for review December 2, 2025 03:38
@sachaudh sachaudh requested a review from a team as a code owner December 2, 2025 03:38
@sachaudh sachaudh requested a review from dvail December 2, 2025 03:38
@sachaudh sachaudh changed the title fix(ui): import required CSS for FeedbackModal styling ROX-31770: Import required CSS for FeedbackModal styling Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.49%. Comparing base (403d48d) to head (b0361e7).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           saif/ROX-31771-fix-my-profile   #18008   +/-   ##
==============================================================
  Coverage                          49.48%   49.49%           
==============================================================
  Files                               2691     2691           
  Lines                             197901   197901           
==============================================================
+ Hits                               97940    97946    +6     
+ Misses                             92321    92315    -6     
  Partials                            7640     7640           
Flag Coverage Δ
go-unit-tests 49.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sachaudh sachaudh force-pushed the saif/ROX-31771-fix-my-profile branch from 403d48d to 69d9c49 Compare December 3, 2025 18:27
@sachaudh sachaudh requested a review from a team as a code owner December 3, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants