ROX-32096: Add no-logical-or-preceding-array-or-object lint rule #18021
+88
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toward Q4 AI goal: help AI to help us.
Also for human finger memory of earlier idiom.
Prevent inconsistencies while writing code in editor instead via change requests by reviewers in contributions.
Problem
Finger memory types
||when??is more precise forrightnode:ArrayExpressionObjectExpressionhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing
Analysis
128 errors in 70 files:
Solution
Use typescript-eslint playground to explore logical expression:
https://typescript-eslint.io/play/#ts=5.9.3&showAST=es&fileType=.tsx
ignoresarray for table above.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.See presence of errors before changes and absence of errors after.