Remove Copy from Secp256k1PrivateKey, Secp256k1PublicKey, StacksAddress, VerifyVoteArgs, and VoteInfo #6361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially replaces #5764
As part of the old PR, it was determined that clone should be removed from StacksAddress, StacksPrivateKey, and StacksPublicKey (removed from VerifyVoteArgs and VoteInfo by necessity)
Not sure if we want to remove the blanket Copy implementation from impl_array_newtype which would remove it from all the various arrays wrappers such as
ConsensusHash
? @kantai let me know if you have an opinion on this (would do in a sep pr if so)?