Skip to content

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented Aug 8, 2025

Partially replaces #5764

As part of the old PR, it was determined that clone should be removed from StacksAddress, StacksPrivateKey, and StacksPublicKey (removed from VerifyVoteArgs and VoteInfo by necessity)

Not sure if we want to remove the blanket Copy implementation from impl_array_newtype which would remove it from all the various arrays wrappers such as ConsensusHash? @kantai let me know if you have an opinion on this (would do in a sep pr if so)?

…ss, VerifyVoteArgs, and VoteInfo

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested review from a team as code owners August 8, 2025 19:23
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jferrant jferrant added this pull request to the merge queue Aug 13, 2025
Merged via the queue into stacks-network:develop with commit b2204fe Aug 13, 2025
3 of 4 checks passed
@jferrant jferrant deleted the chore/remove-copy-from-large-types branch August 13, 2025 16:21
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 70.86721% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.56%. Comparing base (c21aea7) to head (da64d95).
⚠️ Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 30.41% 135 Missing ⚠️
stacks-node/src/tests/nakamoto_integrations.rs 87.17% 30 Missing ⚠️
stacks-node/src/tests/epoch_21.rs 0.00% 16 Missing ⚠️
stacks-node/src/tests/neon_integrations.rs 83.67% 8 Missing ⚠️
stacks-signer/src/monitor_signers.rs 0.00% 8 Missing ⚠️
stacks-common/src/util/secp256k1/native.rs 33.33% 2 Missing ⚠️
...-node/src/burnchains/bitcoin_regtest_controller.rs 50.00% 2 Missing ⚠️
stacks-node/src/keychain.rs 33.33% 2 Missing ⚠️
stacks-signer/src/client/stacks_client.rs 60.00% 2 Missing ⚠️
stackslib/src/core/mempool.rs 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6361      +/-   ##
===========================================
+ Coverage    75.81%   81.56%   +5.75%     
===========================================
  Files          552      552              
  Lines       351807   351980     +173     
===========================================
+ Hits        266724   287096   +20372     
+ Misses       85083    64884   -20199     
Files with missing lines Coverage Δ
clarity/src/vm/costs/mod.rs 81.47% <100.00%> (+2.73%) ⬆️
clarity/src/vm/mod.rs 90.64% <100.00%> (ø)
libsigner/src/signer_set.rs 88.23% <100.00%> (ø)
libsigner/src/tests/signer_state.rs 97.45% <100.00%> (+20.00%) ⬆️
stacks-node/src/nakamoto_node.rs 90.81% <100.00%> (ø)
stacks-node/src/nakamoto_node/miner.rs 83.42% <100.00%> (+0.35%) ⬆️
stacks-node/src/operations.rs 100.00% <100.00%> (+14.77%) ⬆️
stacks-node/src/tests/integrations.rs 99.58% <100.00%> (ø)
stacks-node/src/tests/mempool.rs 99.85% <100.00%> (+99.85%) ⬆️
stacks-node/src/tests/signer/mod.rs 76.98% <100.00%> (-2.97%) ⬇️
... and 53 more

... and 193 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21aea7...da64d95. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants