[Clarity-4] Implement contract post-conditions #6516

obycode · 2025-09-18T21:33:04Z

Implements contract post-conditions as described in #6396 and SIP PR stacksgov/sips#218.

obycode · 2025-09-19T21:31:42Z

In implementing this, I'm wondering if it might be better to make a small change to the with-nft allowance. Currently, it is:

(with-nft contract-id:principal token-name:(string-ascii 128 identifier:T)

I'm wondering if it makes more sense to change that to allow a list of identifiers:

(with-nft contract-id:principal token-name:(string-ascii 128 identifier:(list T 128))

This would allow the list to be built within the code and then passed to a single allowance expression for each NFT.

This just adds the basic support for the syntax and some setup for the full implementation.

That infrastructure is not setup for handling PoX state, and the stacking tracking in the asset maps is not setup yet any way.

obycode · 2025-09-22T18:09:12Z

Remaining work is to handle the with-stacking allowances, but the rest of this can be reviewed now.

hstove

LGTM! Mainly I see that you have some unwritten integration test TODOs, but otherwise everything looks really well tested.

clarity/src/vm/analysis/type_checker/v2_1/natives/post_conditions.rs

obycode · 2025-09-30T15:00:50Z

LGTM! Mainly I see that you have some unwritten integration test TODOs, but otherwise everything looks really well tested.

Thanks @hstove! I actually forgot about those TODOs I had at the bottom. The remaining tests I planned to add were:

Replicate the existing checks in check_with_stacking_allowances but with calls to stack-stx instead of delegate-stx
Duplicate check_restrict_assets_rollback but using as-contract?

Do you see any others that should get added?

We decided to remove this because it doesn't really make sense.

obycode · 2025-10-01T20:12:53Z

@hstove TODOs resolved, additional tests added, and merge conflicts resolved.

hstove

LGTM!

kantai

This looks good to me, just have a few comments

clarity/src/vm/analysis/type_checker/v2_1/natives/post_conditions.rs

pox-locking/src/pox_4.rs

clarity/src/vm/functions/post_conditions.rs

This replaces a `HashSet<String>` which was using the serialized value for quick lookups, but added the extra overhead on setup and use of serializing the values. With this new design, the value is used directly, with no new allocations, and then a linear search is required through the `Vec`, but in the common case, the number of entries will be very low.

This is necessary because the costs-4 contract was updated. I verified that the consensus tests passed if I removed the new functions in that contract.

brice-stacks · 2025-10-09T21:32:50Z

The consensus tests fail because this branch adds new functions into costs-4.clar, so it should be consensus-breaking. I validated that if I removed those new functions, the chainstate matched.

kantai

LGTM!

obycode force-pushed the feat/restrict-assets branch 2 times, most recently from 9a75478 to e02ca38 Compare September 18, 2025 21:39

obycode force-pushed the feat/restrict-assets branch 4 times, most recently from efeeab5 to b922ae9 Compare September 21, 2025 13:19

obycode added 10 commits September 22, 2025 12:09

feat: initial implementation for restric-assets?

35534ab

This just adds the basic support for the syntax and some setup for the full implementation.

feat: add syntax and type-checking for as-contract? and allowances

9672363

chore: fix formatting

e4fc430

fix: add Clarity4 version of test contract

e29ec16

feat: initial implementation of allowances

196e71e

fix: remove ASTRules

0a141ae

fix: error in docs example

7e8698f

fix: copy/paste error

204e848

feat: update with-nft to support list of identifiers

771262c

test: add tests for ft and nft post-conditions

b450cd1

obycode force-pushed the feat/restrict-assets branch from 663c1e9 to b450cd1 Compare September 22, 2025 16:10

obycode added 2 commits September 22, 2025 12:24

feat: add checks for max number of allowances and max NFT identifiers

11c4b14

fix: update test and fix clippy issues

1afa168

obycode marked this pull request as ready for review September 22, 2025 17:47

obycode requested review from a team as code owners September 22, 2025 17:47

obycode requested review from kantai and removed request for kantai September 22, 2025 17:56

test: ignore with-stacking in doc examples tests

156724d

That infrastructure is not setup for handling PoX state, and the stacking tracking in the asset maps is not setup yet any way.

obycode requested review from hstove and kantai September 22, 2025 18:09

fix: typo in tests

df2b581

test: additional rollback tests

ce562a3

hstove reviewed Sep 30, 2025

View reviewed changes

clarity/src/vm/analysis/type_checker/v2_1/natives/post_conditions.rs Outdated Show resolved Hide resolved

obycode added 2 commits September 30, 2025 09:50

docs: update doc example

7806db3

refactor: use non-panicking array access

610c421

obycode added 4 commits September 30, 2025 15:27

test: add cheeck_as_contract_rollback integration test

43b17c5

test: add integration tests for stack-stx allowances

a65dda4

Merge branch 'develop' into feat/restrict-assets

4799797

chore: remove todo for event on allowance violation

c824cde

We decided to remove this because it doesn't really make sense.

obycode requested a review from hstove October 1, 2025 20:12

chore: formatting

a6afc03

hstove previously approved these changes Oct 7, 2025

View reviewed changes

kantai reviewed Oct 8, 2025

View reviewed changes

fix: various improvements suggested in PR review

7c47871

obycode dismissed hstove’s stale review via 7c47871 October 9, 2025 18:07

obycode added 6 commits October 9, 2025 14:25

test: with-nft with wrong identifier type

0a44836

doc: add more detail to with-stacking doc

9e95356

Merge branch 'develop' into feat/restrict-assets

fbe687f

fix: update consensus snapshots

01356c8

This is necessary because the costs-4 contract was updated. I verified that the consensus tests passed if I removed the new functions in that contract.

fix: update other consensus snapshots

8044f76

kantai previously approved these changes Oct 10, 2025

View reviewed changes

obycode linked an issue Oct 10, 2025 that may be closed by this pull request

[Clarity-4] restrict-assets? #6396

Open

obycode mentioned this pull request Oct 10, 2025

[Clarity-4] Cost benchmarking #6591

Open

Merge branch 'develop' into feat/restrict-assets

a74c5f8

obycode dismissed kantai’s stale review via a74c5f8 October 10, 2025 21:54

obycode requested review from hstove and kantai October 10, 2025 21:54

[Clarity-4] Implement contract post-conditions #6516

Are you sure you want to change the base?

[Clarity-4] Implement contract post-conditions #6516

Uh oh!

Conversation

obycode commented Sep 18, 2025

Uh oh!

obycode commented Sep 19, 2025

Uh oh!

obycode commented Sep 22, 2025

Uh oh!

hstove left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

obycode commented Sep 30, 2025

Uh oh!

obycode commented Oct 1, 2025

Uh oh!

hstove left a comment

Choose a reason for hiding this comment

Uh oh!

kantai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brice-stacks commented Oct 9, 2025

Uh oh!

kantai left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants