-
Notifications
You must be signed in to change notification settings - Fork 725
feat: openapi spec cleanup for schemathesis fuzzing and cleaner API error responses #6756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: openapi spec cleanup for schemathesis fuzzing and cleaner API error responses #6756
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (77.46%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6756 +/- ##
===========================================
+ Coverage 67.63% 77.46% +9.82%
===========================================
Files 586 586
Lines 362403 362564 +161
===========================================
+ Hits 245099 280844 +35745
+ Misses 117304 81720 -35584
... and 308 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
BowTiedRadone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simone-stacks Thanks for opening the PR! I've just wrapped up an initial review focused on the specification changes. More reviews to come, as I am trying to check them carefully and ensure we maximize the impact of this effort.
docs/rpc/components/schemas/read-only-function-args.schema.yaml
Outdated
Show resolved
Hide resolved
BowTiedRadone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is in a great spot now! After checking the last two suggestions I left, I believe it's ready to be taken out of draft and get some more eyes on it.
Co-authored-by: Radu Bahmata <92028479+BowTiedRadone@users.noreply.github.com>
Co-authored-by: Radu Bahmata <92028479+BowTiedRadone@users.noreply.github.com>
BowTiedRadone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked again, this looks ready for reviews from reviewers with write access 👍
brice-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I just had one small request that might help with clarity.
| @@ -1,12 +1,9 @@ | |||
| # Deployer address for contract endpoints (standard principal format) | |||
| name: contract_address | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're making changes, maybe we could rename this to deployer_address. contract_address sounds like it should include the contract name, so the fact that it is just the deployer address is a bit surprising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in b06eb08, I also changed some comments in docs/event-dispatcher.md - Is this ok?
b519acc to
84d7624
Compare
|
I just added a small test for the 405 addition in 84d7624 and added 405 in some previous tests @jacinta-stacks @brice-stacks |
Description
Improves OpenAPI schema definitions for better API documentation accuracy and validation.
Also introduces proper 405/404/400 HTTP error responses with allow headers.
These changes improve schema accuracy for tools like Schemathesis and ensure the OpenAPI spec matches actual API behavior.
A summary of the findings can be found here.
Applicable issues
Additional info (benefits, drawbacks, caveats)
Benefits:
Caveats:
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo