Skip to content

Conversation

@hugo-stacks
Copy link

This PR forces the use of the parser v2 when the devtools cargo feature flag is enabled.
This feature flag is also used to enable directly calling private_function.
Clarinet has been forcing parser v2 for the past ~3 years by forcing contract the epoch on contracts to be >= 2.1. But it has a few unwanted side effects.

This will eventually become unnecessary when we are able to merge #3662, but for now, the block validation is failing.

By adding this check here with the feature flag, we'll be able to remove the epoch hack in Clarinet.

brice-stacks
brice-stacks previously approved these changes Dec 16, 2025
Copy link
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! I just commented on one little nit about the style used for the feature-gating.

brice-stacks
brice-stacks previously approved these changes Dec 17, 2025
Copy link
Contributor

@federico-stacks federico-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up: I allowed the CI workflow execution, and it surfaced a Rust formatting issue.

@hugo-stacks
Copy link
Author

Thanks @federico-stacks, that should be good

Copy link
Contributor

@federico-stacks federico-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy issue this time :)

You probably already know, but just in case: you can save some time by running these locally to check formatting and clippy warnings:

  • cargo fmt-stacks
  • cargo clippy-stacks

(dnd current rust version is 1.92.0)

@hugo-stacks
Copy link
Author

Yeah clippy was already complaining after the first commit/ And I made it worse in the second commit (completely broke it). Should be good now

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.06%. Comparing base (4f535d8) to head (f09f924).
⚠️ Report is 8 commits behind head on develop.

❌ Your project status has failed because the head coverage (69.06%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4f535d8) and HEAD (f09f924). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (4f535d8) HEAD (f09f924)
82 66
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6764      +/-   ##
===========================================
- Coverage    77.77%   69.06%   -8.72%     
===========================================
  Files          585      585              
  Lines       361916   361918       +2     
===========================================
- Hits        281498   249941   -31557     
- Misses       80418   111977   +31559     
Files with missing lines Coverage Δ
clarity/src/vm/ast/mod.rs 70.50% <100.00%> (-10.16%) ⬇️

... and 339 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f535d8...f09f924. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brice-stacks brice-stacks added this pull request to the merge queue Jan 12, 2026
Merged via the queue into stacks-network:develop with commit d2ecce6 Jan 12, 2026
314 of 317 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants