-
Notifications
You must be signed in to change notification settings - Fork 724
Fix: burn view calculations in signer #6782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: burn view calculations in signer #6782
Conversation
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (74.18%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/3.3.0.0.4 #6782 +/- ##
=====================================================
- Coverage 78.40% 74.18% -4.23%
=====================================================
Files 585 587 +2
Lines 361384 361777 +393
=====================================================
- Hits 283360 268373 -14987
- Misses 78024 93404 +15380
... and 248 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
7e6f2b1 to
29af4a6
Compare
* add `/v3/tenures/tip_metadata` for obtaining burn_view metadata, with openapi spec * correct the signer burn_view calculations, with e2e tests
29af4a6 to
afb1113
Compare
brice-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jacinta-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit about copyright.
911924b
7baa99a
into
stacks-network:release/3.3.0.0.4
This fixes some of the burn view calculations used by signers to evaluate proposals
/v3/tenures/tip_metadatafor obtaining burn_view metadata