Skip to content

Fix: burn view calculations in signer#6782

Merged
aaronb-stacks merged 2 commits intostacks-network:release/3.3.0.0.4from
aaronb-stacks:fix/change-burn-view
Jan 8, 2026
Merged

Fix: burn view calculations in signer#6782
aaronb-stacks merged 2 commits intostacks-network:release/3.3.0.0.4from
aaronb-stacks:fix/change-burn-view

Conversation

@aaronb-stacks
Copy link
Contributor

This fixes some of the burn view calculations used by signers to evaluate proposals

  • add /v3/tenures/tip_metadata for obtaining burn_view metadata
  • correct the signer burn_view calculations, with e2e tests

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 55.43131% with 279 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.18%. Comparing base (267c7ef) to head (911924b).
⚠️ Report is 3 commits behind head on release/3.3.0.0.4.

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 0.00% 136 Missing ⚠️
stackslib/src/chainstate/tests/runtime_tests.rs 0.00% 64 Missing ⚠️
stackslib/src/net/api/get_tenure_tip_meta.rs 67.81% 28 Missing ⚠️
stacks-signer/src/chainstate/v2.rs 22.22% 14 Missing ⚠️
stacks-signer/src/chainstate/tests/v2.rs 89.01% 10 Missing ⚠️
stacks-signer/src/chainstate/v1.rs 61.53% 10 Missing ⚠️
stacks-signer/src/client/mod.rs 83.33% 6 Missing ⚠️
stacks-signer/src/tests/signer_state.rs 45.45% 6 Missing ⚠️
stackslib/src/net/api/gettenuretip.rs 40.00% 3 Missing ⚠️
clarity/src/vm/functions/post_conditions.rs 66.66% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (74.18%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/3.3.0.0.4    #6782      +/-   ##
=====================================================
- Coverage              78.40%   74.18%   -4.23%     
=====================================================
  Files                    585      587       +2     
  Lines                 361384   361777     +393     
=====================================================
- Hits                  283360   268373   -14987     
- Misses                 78024    93404   +15380     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 75.55% <ø> (ø)
clarity-types/src/tests/types/signatures.rs 94.58% <100.00%> (-4.54%) ⬇️
clarity-types/src/types/signatures.rs 92.21% <100.00%> (-0.12%) ⬇️
stacks-node/src/tests/signer/mod.rs 71.32% <100.00%> (+1.90%) ⬆️
stacks-signer/src/chainstate/mod.rs 89.66% <100.00%> (+1.47%) ⬆️
stacks-signer/src/chainstate/tests/mod.rs 100.00% <100.00%> (ø)
stacks-signer/src/chainstate/tests/v1.rs 97.31% <100.00%> (-2.69%) ⬇️
stacks-signer/src/client/stacks_client.rs 84.33% <100.00%> (-4.47%) ⬇️
stacks-signer/src/v0/signer_state.rs 75.57% <100.00%> (+4.45%) ⬆️
stackslib/src/net/api/mod.rs 93.33% <100.00%> (+0.18%) ⬆️
... and 11 more

... and 248 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267c7ef...911924b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aaronb-stacks aaronb-stacks force-pushed the fix/change-burn-view branch 2 times, most recently from 7e6f2b1 to 29af4a6 Compare January 8, 2026 15:35
@aaronb-stacks aaronb-stacks changed the base branch from develop to release/3.3.0.0.4 January 8, 2026 15:36
@aaronb-stacks aaronb-stacks reopened this Jan 8, 2026
* add `/v3/tenures/tip_metadata` for obtaining burn_view metadata, with openapi spec
* correct the signer burn_view calculations, with e2e tests
brice-stacks
brice-stacks previously approved these changes Jan 8, 2026
Copy link
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jacinta-stacks
jacinta-stacks previously approved these changes Jan 8, 2026
Copy link
Contributor

@jacinta-stacks jacinta-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit about copyright.

@aaronb-stacks aaronb-stacks merged commit 7baa99a into stacks-network:release/3.3.0.0.4 Jan 8, 2026
1 of 2 checks passed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants